From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: vm: create a vnic with vhostuser backend ...................................................................... Patch Set 31: (1 comment) https://gerrit.ovirt.org/#/c/74327/31/lib/vdsm/virt/vmdevices/network.py File lib/vdsm/virt/vmdevices/network.py: Line 303: detach_detachable(self.hostdev) Line 304: else: Line 305: bridge_info = supervdsm.getProxy().ovs_bridge(self.network) Line 306: if bridge_info and bridge_info['dpdk_enabled']: Line 307: self._is_vhostuser = True > This becomes too complicated. It's sad that we need to store data just in order not to bother supervdsm during __init__. But yes, it's my option 1. I kinda likeMartin's suggestion. in vm.py we can have if not self.recovering: self._setup_devices() else: self._recover_devices() # <== add this which should call a device.recover() which would speak with supervdsm. Line 308: self._create_vhost_port(bridge_info['name']) Line 309: Line 310: def teardown(self): Line 311: if self.is_hostdevice: -- To view, visit https://gerrit.ovirt.org/74327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie81cf52f17ffe01713dd6502d68c4b17c64e5335 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
