From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: net: dump bonding options on network-service start ...................................................................... Patch Set 10: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/78006/10/static/usr/lib/systemd/system/vdsm-network.service.in File static/usr/lib/systemd/system/vdsm-network.service.in: Line 8: Type=oneshot Line 9: EnvironmentFile=-/etc/sysconfig/vdsm Line 10: ExecStartPre=@BINDIR@/vdsm-tool --vvverbose --append --logfile=@VDSMLOGDIR@/upgrade.log upgrade-networks Line 11: ExecStart=@BINDIR@/vdsm-tool restore-nets Line 12: ExecStart=@BINDIR@/vdsm-tool dump-bonding-options > This should appear before the upgrade-networks, as upgrade-networks may try Should it not appear even earlier, in vdsm-network-init.service ? Line 13: RemainAfterExit=yes Line 14: Line 15: [Install] -- To view, visit https://gerrit.ovirt.org/78006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98f7c691a2a86d152ebcb81e1d96f9b0d83fa698 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
