From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: ssl: handle handshake errors ...................................................................... Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/79668/7/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py: Line 254: elif err.args[0] == ssl.SSL_ERROR_WANT_WRITE: Line 255: self.want_write = True Line 256: else: Line 257: dispatcher.close() Line 258: except socket.error: silently ignoring these two errors is counter intuitive. Maybe you can add a comment for future developers? Line 259: dispatcher.close() Line 260: else: Line 261: self.want_read = self.want_write = True Line 262: self._is_handshaking = False -- To view, visit https://gerrit.ovirt.org/79668 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99cfa35e608f429640455c35495be1783854e3da Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
