From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: m2c: uses different protocol constant names ...................................................................... Patch Set 4: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/79664/4/lib/vdsm/m2cutils.py File lib/vdsm/m2cutils.py: Line 37: except ImportError as e: Line 38: raise compat.Unsupported(str(e)) Line 39: Line 40: CLIENT_PROTOCOL = "sslv23" Line 41: SSL_OP_NO_TLSv1_1 = 268435456 0x10000000 is SOOO much more readable. Line 42: Line 43: DEFAULT_ACCEPT_TIMEOUT = 5 Line 44: SOCKET_DEFAULT_TIMEOUT = socket._GLOBAL_DEFAULT_TIMEOUT Line 45: -- To view, visit https://gerrit.ovirt.org/79664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
