From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: cmdutils: add env to exec_cmd()'s args ...................................................................... Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/79694/10/tests/common/cmdutils_test.py File tests/common/cmdutils_test.py: Line 147: self.assertEqual(out, b'') Line 148: Line 149: def test_exec_cmd_with_env(self): Line 150: rc, out, err = cmdutils.exec_cmd( Line 151: ('sh', '-c', 'echo $XXX'), env={'XXX': 'hello'}) > printenv XXX would be little nicer. but more obscure - I did not know of it. Line 152: self.assertEqual(rc, 0) -- To view, visit https://gerrit.ovirt.org/79694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I109c50c4dd85347e12e8a9a11963b0cded685536 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
