From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: Openstacknet hooks must check provider type to run ...................................................................... Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/80155/1//COMMIT_MSG Commit Message: PS1, Line 9: drive driver Line 9: When an openstacknet drive is installed along with another Line 10: external network provider, its hooks were failing when an Line 11: external network nic (non openstack) was handled. Line 12: This patch modifies the hooks to check if the nic handled Line 13: is of type OPENSTACK_NET_PROVIDER_TYPE before doing which value is passed by the OVN provider? I thought that only the pluginType would differ. Line 14: any other operation. Line 15: Line 16: Change-Id: Ie88b6793fde74d9cd3b6a308c75c10d02c05a627 Line 11: external network nic (non openstack) was handled. Line 12: This patch modifies the hooks to check if the nic handled Line 13: is of type OPENSTACK_NET_PROVIDER_TYPE before doing Line 14: any other operation. Line 15: wasn't there an open bug about this? Line 16: Change-Id: Ie88b6793fde74d9cd3b6a308c75c10d02c05a627 -- To view, visit https://gerrit.ovirt.org/80155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie88b6793fde74d9cd3b6a308c75c10d02c05a627 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dominik Holler <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
