From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: virt net: Avoid removing the display network when not defined ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/80393/1/lib/vdsm/virt/vmdevices/graphics.py File lib/vdsm/virt/vmdevices/graphics.py: Line 70: display_ip = '0' Line 71: self.specParams['displayIp'] = display_ip Line 72: Line 73: def teardown(self): Line 74: display_network = self.specParams['displayNetwork'] > VmGraphicsDeviceSpecParams: &VmGraphicsDeviceSpecParams I don't really understand your worry, Francesco. I don't believe any living Engine misses displaysNetwork; it can arrive only from ancient migrated VMs. Missing displayNetwork is handled by the compat code in Vm class. Do you suggest to move (some?) of that code to here? I don't think that would be a positive step. Line 75: if display_network: Line 76: libvirtnetwork.delete_network(display_network, self.vmid) Line 77: Line 78: def getSpiceVmcChannelsXML(self): -- To view, visit https://gerrit.ovirt.org/80393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd3faedd952a53bbd36a3e101079a65c8f6cf1ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
