From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: net: Introduce iface interface driver ...................................................................... Patch Set 10: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/80169/10/lib/vdsm/network/link/iface.py File lib/vdsm/network/link/iface.py: PS10, Line 129: if self._is_dpdk_type: : info = dpdk.link_info(self._dev) : else: : info = link.get_link(self._dev) : return info > maybe call return right away? this is super simple function, we can do that I don't mind either way. -- To view, visit https://gerrit.ovirt.org/80169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5d50f47194f023826aafa5e3e77ec495ea4299c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
