From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: dpdk: call flush ip only on non dpdk devices ...................................................................... Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/80688/1/lib/vdsm/network/ifacquire.py File lib/vdsm/network/ifacquire.py: Line 155: return Line 156: # TODO: Tell NetworkManager to unmanage this iface. Line 157: dhclient.kill(iface, family=4) Line 158: dhclient.kill(iface, family=6) Line 159: if not dpdk.is_dpdk(iface): does dhclient run on dpdk iface? wouldn't it be better to bail off early, just as if the iface did not exist? -- To view, visit https://gerrit.ovirt.org/80688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia768a1fbb6c17bf524cd4bf16abd742cb942bd2e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
