From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has uploaded a new change for review.
Change subject: vdsm.tool.service: unbreak tool.service ...................................................................... vdsm.tool.service: unbreak tool.service In commit 53a2562 I have avoided execCmd splitting its output to lines, but I ignored a case where the split was actually used. I do not yet understand how did this passed my verification. Change-Id: I494871fc2834291143f7dc4c16ccc507ad5a1778 Signed-off-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/tool/service.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/80908/1 diff --git a/lib/vdsm/tool/service.py b/lib/vdsm/tool/service.py index 957e777..fdd1b11 100644 --- a/lib/vdsm/tool/service.py +++ b/lib/vdsm/tool/service.py @@ -116,7 +116,7 @@ # If unit file type was specified, don't override it. if srvName.count('.') < 1: fullName = srvName + ".service" - for line in out: + for line in out.splitlines(): if fullName == line.split(" ", 1)[0]: return systemctlFun(fullName) raise ServiceNotExistError("%s is not native systemctl service" % -- To view, visit https://gerrit.ovirt.org/80908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I494871fc2834291143f7dc4c16ccc507ad5a1778 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
