From Yaniv Bronhaim <[email protected]>: Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/78916 )
Change subject: stomp: handle incoming heartbeats ...................................................................... stomp: handle incoming heartbeats According to stomp specification, Heart-beating can optionally be used to test the healthiness of the underlying TCP connection and to make sure that the remote end is alive and kicking. [1] until now, we ignored incoming heartbeats and raised ValueError when their value was not 0. This patch gets the incoming heartbeats and updates the dispatcher according to their value. incoming heartbeat will be updated every time a new frame will be received, indicating connection is still active. If timeout has exceeded, the frame handler (client or server) will handle it according to its implementation. [1] https://stomp.github.io/stomp-specification-1.2.html#Heart-beating Change-Id: Ib9558ecddef3b57d37cfe4257c1c0ab4f2015064 Signed-off-by: Irit Goihman <[email protected]> Bug-Url: https://bugzilla.redhat.com/1376843 --- M lib/yajsonrpc/stomp.py M tests/stompAsyncDispatcherTests.py 2 files changed, 38 insertions(+), 7 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved Jenkins CI: Passed CI tests Irit Goihman: Verified Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9558ecddef3b57d37cfe4257c1c0ab4f2015064 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Irit Goihman <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
