From Yaniv Bronhaim <[email protected]>: Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/80911 )
Change subject: stomp: fix AsyncDispatcher next_check_interval ...................................................................... stomp: fix AsyncDispatcher next_check_interval If next_check_interval returns 0, asyncore loop is triggerred. In case of no outgoing heartbeat, the function doesn't ignore the calculation and returns 0, which causes the loop to be triggerred constantly and send heartbeats. On server side outgoing heartbeats are always greater than 0 so we didn't encounter this behavior before. When we added the same functionality to client side, where outgoing heartbeat is 0 by default, we encountered high cpu usage. Change-Id: I4e7fe82f80535ff851eaf909de194419511154ba Signed-off-by: Irit Goihman <[email protected]> Bug-Url: https://bugzilla.redhat.com/1376843 --- M lib/yajsonrpc/stomp.py M tests/stompAsyncDispatcherTests.py 2 files changed, 23 insertions(+), 7 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved; Passed CI tests Irit Goihman: Verified -- To view, visit https://gerrit.ovirt.org/80911 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e7fe82f80535ff851eaf909de194419511154ba Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Irit Goihman <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
