Dan Kenigsberg has posted comments on this change.
Change subject: Added gluster volume top functionalities
......................................................................
Patch Set 9: I would prefer that you didn't submit this
(2 inline comments)
....................................................
Commit Message
Line 3: AuthorDate: 2012-09-06 19:33:25 +0530
Line 4: Commit: Timothy Asir <tjeya...@redhat.com>
Line 5: CommitDate: 2012-12-05 18:00:21 +0530
Line 6:
Line 7: Added gluster volume top functionalities
could you provide a short intro+refs for what is volumetop and its methods?
Line 8:
Line 9: new verb: glusterVolumeTopOpen
Line 10: output structure:
Line 11: When nfs is False:
....................................................
File vdsm/gluster/cli.py
Line 947: raise
ge.GlusterXmlErrorException(err=[etree.tostring(xmltree)])
Line 948:
Line 949:
Line 950: @exportToSuperVdsm
Line 951: def volumeTopOpen(volumeName, brickName=None, nfs=False, listCount=0):
what does brickName=None mean? all bricks? could you have both brickname and
nfs=True?
I understand that you are mimicking gluster cli, but I'd prefer a more
substantial documentation.
Line 952: """
Line 953: Returns:
Line 954: When nfs=True:
Line 955: [{'nfs': SERVER-NAME,
--
To view, visit http://gerrit.ovirt.org/7844
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I96486363a9acb7472014a67fcd2d5185d4f3c428
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
