Saggi Mizrahi has posted comments on this change. Change subject: pep8 fixes for vdsm file ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/vdsm Line 118: "to run from user %s" % (constants.VDSM_USER, username) Line 119: ) Line 120: group = grp.getgrnam(constants.VDSM_GROUP) Line 121: assert ((constants.VDSM_USER in group.gr_mem Line 122: or pwd.getpwnam(constants.VDSM_USER).pw_gid == group.gr_gid), operators (in this case "or") should be on the previous line according to pep8 Line 123: "VDSM failed to start: vdsm user is not in KVM group") Line 124: Line 125: if __name__ == '__main__': Line 126: __assertVdsmUser() -- To view, visit http://gerrit.ovirt.org/9698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24e861a6accc8190875f5e39f20f7deee4abd89b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
