Saggi Mizrahi has posted comments on this change.
Change subject: upgrade: reallocate the metadata slots when needed
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/imageRepository/formatConverter.py
Line 156:
Line 157: if metaOffset < metaMaxSlot:
Line 158: continue
Line 159:
Line 160: log.debug("Reallocating metadata slot %s for volume %s",
This happens per volume, on domains with a lot of volumes this will flood the
log with useless junk.
Only log this information in case something fails.
instead of
log.debug("Domain something on vol '%s'", volId)
change to:
try:
doSomething()
except:
log.error("Something failed for vol '%s'", volId)
Line 161: metaOffset, vol.volUUID)
Line 162: metaContent = vol.getMetadata()
Line 163:
Line 164: with vol._tagCreateLock:
--
To view, visit http://gerrit.ovirt.org/9660
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b6a85969a10b5e2b852031fc510aabcc2d5276
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
