Zhou Zheng Sheng has posted comments on this change.
Change subject: PEP8 cleanup for *.py under vdsm_hooks
......................................................................
Patch Set 1: (2 inline comments)
A string literal is changed.
....................................................
File vdsm_hooks/hostusb/after_vm_destroy.py
Line 71
Line 72
Line 73
Line 74
Line 75
It seems you delete the "," .
Line 75: regex = re.compile('^0x[\d,A-F,a-f]{4}$')
Line 76: for usb in os.environ['hostusb'].split('&'):
Line 77: vendorid, productid = usb.split(':')
Line 78: if (len(regex.findall(vendorid)) != 1 or
Line 79: len(regex.findall(productid)) != 1):
It's better if you add 4 spaces to indent this line so it can be distinguished
from the following block. Like this,
if (len(regex.findall(vendorid)) != 1 or
len(regex.findall(productid)) != 1):
sys.stderr.write('hostusb after_vm_destroy: bad input, '
Line 80: sys.stderr.write('hostusb after_vm_destroy: bad input '
Line 81: 'expected 0x0000 format for vendor
and '
Line 82: 'product id, input: %s:%s\n' %
Line 83: (vendorid, productid))
--
To view, visit http://gerrit.ovirt.org/9734
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc798bb4598291d52e2cebce1ed65228f657ebbd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
