Antoni Segura Puimedon has posted comments on this change. Change subject: netwiring: [2/4] Add API definitions. ......................................................................
Patch Set 6: (1 inline comment) .................................................... File vdsm/BindingXMLRPC.py Line 263: return vm.hotunplugNic(params) Line 264: Line 265: def vmUpdateDevice(self, vmId, params): Line 266: vm = API.VM(vmId) Line 267: return vm.updateDevice(params) You're right. I will reinstate updateDevice in patch set-14 now. So this and the following patch will be right. Line 268: Line 269: def vmSnapshot(self, vmId, snapDrives): Line 270: vm = API.VM(vmId) Line 271: return vm.snapshot(snapDrives) -- To view, visit http://gerrit.ovirt.org/9560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d8352f237dbe0229dff368f7c1dfa4f5f8fc766 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: ShaoHe Feng <shao...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
