Amador Pahim has posted comments on this change. Change subject: Online check ksmState and ksmPages. ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/API.py Line 1126: stats['momStatus'] = self._cif.mom.getStatus() Line 1127: stats.update(self._cif.mom.getKsmStats()) Line 1128: else: Line 1129: stats['momStatus'] = 'disabled' Line 1130: stats['ksmState'] = self._cif.running() Yes, it has "import ksm", wich brings running(). Anyway, changing to ksm.running() Thank you for your review. Line 1131: stats['ksmPages'] = self._cif.npages() Line 1132: stats['ksmCpu'] = self._cif.ksmMonitor.cpuUsage Line 1133: stats['memShared'] = self._memShared() / Mbytes Line 1134: -- To view, visit http://gerrit.ovirt.org/9510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84c2f8b80529a47662bdeac80bb3f71defd0758a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
