Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Attaching a console should be controllable
......................................................................
Patch Set 5: Looks good to me, approved
(1 inline comment)
....................................................
File vdsm_api/vdsmapi-schema.json
Line 2350: # Properties of a VM console device.
Line 2351: #
Line 2352: # @deviceType: The device type (always @console)
Line 2353: #
Line 2354: # @deviceId: A unique ID for this device
Ok... I can leave the api with virtio console as a default.
If we ever need to add serial console we could add consoleType parameter.
Line 2355: #
Line 2356: # Since: 4.10.0
Line 2357: ##
Line 2358: {'type': 'VmConsoleDevice',
--
To view, visit http://gerrit.ovirt.org/9359
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie92b0ad693fdde7eae9091d944403ac4477eb186
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
