Dan Kenigsberg has posted comments on this change. Change subject: Fix flake8 warnings for network code. ......................................................................
Patch Set 2: Looks good to me, approved (1 inline comment) .................................................... File vdsm/configNetwork.py Line 187: def createLibvirtNetwork(self, network, bridged=True, iface=None, Line 188: skipBackup=False): Line 189: netName = netinfo.LIBVIRT_NET_PREFIX + network Line 190: if bridged: Line 191: netXml = '''<network><name>%s</name><forward mode='bridge'/> no idea why you kept this, and changed the other branch. but this is not really urgent. Line 192: <bridge name='%s'/></network>''' % (escape(netName), Line 193: escape(network)) Line 194: else: Line 195: netXml = ( -- To view, visit http://gerrit.ovirt.org/9846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59cd4d8bb41c1ce71b91b45ff7fe2f10f25eb577 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
