Dan Kenigsberg has posted comments on this change. Change subject: Multiple pep8 fixes ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) question inline. .................................................... File vdsm/BindingXMLRPC.py Line 140: Line 141: if self.enableSSL: Line 142: KEYFILE, CERTFILE, CACERT = self._getKeyCertFilenames() Line 143: s = SecureXMLRPCServer.SecureThreadedXMLRPCServer( Line 144: server_address, I understand that it's kosher, but it still stinks. Or is it only me who thinks that this indentation in this context is confusing and misleading? How about using a longer variable name for "s"? Line 145: keyfile=KEYFILE, certfile=CERTFILE, ca_certs=CACERT, Line 146: timeout=self.serverRespTimeout, Line 147: requestHandler=LoggingHandler) Line 148: else: -- To view, visit http://gerrit.ovirt.org/10037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52878345d5b46eec0fea74ce87d435df629eedfe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
