Saggi Mizrahi has uploaded a new change for review.

Change subject: caps nits
......................................................................

caps nits

Change-Id: I231ede3f64010a3f9d3801914bc46088600befd2
Signed-off-by: Saggi Mizrahi <[email protected]>
---
M vdsm/caps.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/10047/1

diff --git a/vdsm/caps.py b/vdsm/caps.py
index d1297c9..987a918 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -299,8 +299,8 @@
 def _getIfaceByIP(addr, fileName='/proc/net/route'):
     remote = struct.unpack('I', socket.inet_aton(addr))[0]
     for line in itertools.islice(file(fileName), 1, None):
-        iface, dest, gateway, flags, refcnt, use, metric, \
-            mask, mtu, window, irtt = line.split()
+        (iface, dest, gateway, flags, refcnt, use, metric,
+         mask, mtu, window, irtt) = line.split()
         dest = int(dest, 16)
         mask = int(mask, 16)
         if remote & mask == dest & mask:
@@ -311,8 +311,8 @@
 def _getKeyPackages():
     def kernelDict():
         try:
-            ver, rel = file('/proc/sys/kernel/osrelease').read(). \
-                strip().split('-', 1)
+            with open('/proc/sys/kernel/osrelease', "r") as f:
+                ver, rel = f.read().strip().split('-', 1)
         except:
             logging.error('kernel release not found', exc_info=True)
             ver, rel = '0', '0'


--
To view, visit http://gerrit.ovirt.org/10047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I231ede3f64010a3f9d3801914bc46088600befd2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to