Adam Litke has posted comments on this change. Change subject: Refactor communication infra ......................................................................
Patch Set 10: (4 inline comments) A few minor (but important comments). I am okay with merging this after they are resolved. .................................................... File tests/jsonRpcTests.py Line 100: def handleMessage(self, msgCtx): Line 101: msgCtx.sendReply(msgCtx.data) Line 102: Line 103: Line 104: class TCPRactorClient(object): TCPReactorClient Line 105: def __init__(self, address): Line 106: self.sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) Line 107: self.address = address Line 108: Line 162: fire off the shoulder of Orion. I've watched c-beams glitter Line 163: in the dark near the Tannhauser Gate. All those ... moments Line 164: will be lost in time, like tears...in rain. Time to die.""" Line 165: # (C) Blade Runner Line 166: Please do not put copyrighted text in the source code. Use lorem ipsum instead. Line 167: msgHandler = _EchoMessageHandler() Line 168: Line 169: def serve(reactor): Line 170: try: Line 223: Peasant 3: Well, she turned me into a newt! Line 224: Sir Bedevere: A newt? Line 225: Peasant 3: [meekly after a long pause] ... I got better. Line 226: Crowd: [shouts] Burn her anyway!""" Line 227: # (C) Monty Python and the Holdy Grail Again... Line 228: Line 229: bridge = _DummyBridge() Line 230: with constructServer(reactorType, bridge) as (server, clientFactory): Line 231: client = clientFactory() Line 254: Dennis: Oh, king eh? Very nice. And how'd you get that, eh? Line 255: By exploiting the workers. By hanging on to outdated Line 256: imperialist dogma which perpetuates the economic and Line 257: social differences in our society.""" Line 258: # (C) Monty Python and the Holdy Grail ... Line 259: Line 260: bridge = _DummyBridge() Line 261: with constructServer(reactorType, bridge) as (server, clientFactory): Line 262: client = clientFactory() -- To view, visit http://gerrit.ovirt.org/9986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a65364824cc8433263ccf6ed44f1f97141eff2c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
