ShaoHe Feng has posted comments on this change. Change subject: fix two parameters of VmParameters in vdsmapi schema ......................................................................
Patch Set 1: I have update my git repository. This is not fixed yet. there are two places that define "smpCoresPerSocket" and "smpThreadsPerCore". only one place is right to set optional. I found this bug when I review your patch after is was merged, sorry I did not notice it was merged at that time. http://gerrit.ovirt.org/7839 There are many schema syntax errors on the gerrit. IMO it is impossible to catch these errors by our eyes. So I submit a patch to validate the schema at build time , and it was merged . http://gerrit.ovirt.org/#/c/9433/ But the optional error can not be caught at build time. IMO the the process-schema.py should be improved to catch this kind of error. -- To view, visit http://gerrit.ovirt.org/9112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9bce789c1d33357e079ff47300a99a59025834e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
