Dan Kenigsberg has submitted this change and it was merged. Change subject: Make advanced process invocations part of execCmd ......................................................................
Make advanced process invocations part of execCmd There are a bunch of places in the code where priority is set using ad hoc command concatenation. This is hard to understand and error prone. This patch adds this as a feature of execCmd so proper use is always enforced. - niceness can be set with the nice parameter - ionice class and class data can also be set with the appropriate parameters - setsid can be set as a boolean with setsid=True Change-Id: I5abd61c03ce907ea94761f0209a4626669051eb1 Signed-off-by: Saggi Mizrahi <[email protected]> --- M tests/miscTests.py M vdsm/constants.py.in M vdsm/storage/misc.py M vdsm/storage/safelease.py M vdsm/storage/volume.py M vdsm/sudoers.vdsm.in 6 files changed, 61 insertions(+), 22 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5abd61c03ce907ea94761f0209a4626669051eb1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
