Saggi Mizrahi has posted comments on this change.

Change subject: Check if log file exist on startup and log directory is 
accessible
......................................................................


Patch Set 2: I would prefer that you didn't submit this

It don't understand what you are doing.
Shouldn't you make sure all log files are writable (for rotate).
Just use glob

--
To view, visit http://gerrit.ovirt.org/10194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I300adc5ac3d9b12fee49023a54e5ffb4dee98da1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to