Dan Kenigsberg has posted comments on this change.
Change subject: Add correct TUNSETIFF ioctl value for IBM Power (ppc64) in
tcTests.py
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File tests/tcTests.py
Line 93: arch = platform.machine()
Line 94: if arch == 'x86_64':
Line 95: _TUNSETIFF = 0x400454ca
Line 96: elif arch == 'ppc64':
Line 97: _TUNSETIFF = 0x800454ca
I shall trust you about the value. Too bad we cannot import it from somewhere.
An if/elif clause without "else" makes me shiver.
How about
else:
raise SkipTest("unsupported arch")
?
Line 98:
Line 99: _deviceListener = None
Line 100:
Line 101: def addDevice(self):
--
To view, visit http://gerrit.ovirt.org/10202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a3831761aed81932466e29d88f5eb50bf5ce23d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Pradipta Banerjee <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
