Dan Kenigsberg has posted comments on this change.
Change subject: Handling removing file Exceptions.
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/utils.py
Line 63: except OSError as e:
Line 64: if e.errno == errno.ENOENT:
Line 65: logging.warning("File: %s already removed", fileToRemove)
Line 66: else:
Line 67: logging.error("Removing file: %s failed", fileToRemove,
this log is pointless as it would be logged again when the re-raised exception
is caught.
if for some reason you want to keep, please fix the pep8 indentation here, or
this would break build on f18.
Line 68:
exc_info=True)
Line 69: raise
Line 70:
Line 71: def readMemInfo():
--
To view, visit http://gerrit.ovirt.org/8625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If76e158ad69921d382e3d42ae45486534b9379f9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
