Moti Asayag has posted comments on this change. Change subject: vdsm: Support guest agent selective ip reporting ......................................................................
Patch Set 2: (2 inline comments) .................................................... Commit Message Line 5: CommitDate: 2012-12-19 01:14:13 +0200 Line 6: Line 7: vdsm: Support guest agent selective ip reporting Line 8: Line 9: The guest agent might not report inet element, I guess it is a matter of api between the guest-agent to VDSM: If the nic has no ipv4, how should it be reported ? either as an empty list or not be reported at all. At the moment the guest agent doesn't report the inet element which causes failure on processing it. Line 10: therefore processing its input should support it and Line 11: return an emply ips list instead. Line 12: Line 13: Change-Id: I5264058737cc2b53b9bfa22d344bf26c8d269f87 .................................................... File vdsm/guestIF.py Line 136: for iface in args['interfaces']: Line 137: iface['name'] = _filterXmlChars(iface['name']) Line 138: iface['hw'] = _filterXmlChars(iface['hw']) Line 139: if 'inet' in iface: Line 140: iface['inet'] = map(_filterXmlChars, iface['inet']) will change. Line 141: else: Line 142: iface['inet'] = [] Line 143: if 'inet6' in iface: Line 144: iface['inet6'] = map(_filterXmlChars, iface['inet6']) -- To view, visit http://gerrit.ovirt.org/10214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5264058737cc2b53b9bfa22d344bf26c8d269f87 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
