Saggi Mizrahi has posted comments on this change.

Change subject: tests: Test schema validity
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File tests/schemaTests.py
Line 34:     for f in localpath, installedpath:
Line 35:         if os.access(f, os.R_OK):
Line 36:             return f
Line 37:     raise Exception("Unable to find schema in %s or %s",
Line 38:                     localpath, installedpath)
You need to manually format the string with the % operator
Line 39: 
Line 40: 
Line 41: class SchemaTest(TestCaseBase):
Line 42:     def setUp(self):


--
To view, visit http://gerrit.ovirt.org/10050
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7680aaf8eb41546e3a8d38e405c7f9ed8bdd192
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to