Vinzenz Feenstra has posted comments on this change.
Change subject: Improvement of the GuestAgent class memory usage
......................................................................
Patch Set 8: (3 inline comments)
....................................................
File tests/guestIFTests.py
Line 102: t = testCase(*t)
Line 103: fakeGuestAgent._handleMessage(t.msgType, t.message)
Line 104: for (k, v) in t.assertDict.iteritems():
Line 105: self.assertEqual(fakeGuestAgent.guestInfo[k], v)
Line 106:
Done
Line 107: # Guest agent must not be stopped
Line 108: fakeGuestAgent._stopped = False
Line 109: # Retrieving configured message size
Line 110: maxMessageSize = config.getint('vars',
Line 125: for chunk in messageChunks(msg_str):
Line 126: fakeGuestAgent._handleData(chunk)
Line 127: if chunk[-1] != '\n':
Line 128: self.assertEqual(fakeGuestAgent._messageState,
Line 129: guestIF.MessageState.TOO_BIG)
That case is covered by the next line outside of the loop.
Line 130:
Line 131: # At the end the message state has to be NORMAL again
Line 132: self.assertEqual(fakeGuestAgent._messageState,
Line 133: guestIF.MessageState.NORMAL)
Line 132: self.assertEqual(fakeGuestAgent._messageState,
Line 133: guestIF.MessageState.NORMAL)
Line 134:
Line 135: for (k, v) in t.assertDict.iteritems():
Line 136: self.assertEqual(fakeGuestAgent.guestInfo[k], v)
Done
--
To view, visit http://gerrit.ovirt.org/9239
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf6274bb10c9e3b80962b69c5df316f03ee21214
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
