Vinzenz Feenstra has posted comments on this change.
Change subject: add createVm support of cputune
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm_api/vdsmapi-schema.json
Line 2482: # @quota: #optional Max bandwidth vCPU can consume
Line 2483: #
Line 2484: # @shares: #optional Relative share of CPU compared with
other VMs
Line 2485: #
Line 2486: # Since: 4.10.0
4.10.3?
Line 2487: ##
Line 2488: {'type': 'CpuTuneParams',
Line 2489: 'data': {'*cpuPinning': 'StringMap', '*emulator_period': 'uint',
Line 2490: '*emulator_quota': 'int', '*period': 'uint',
Line 2496: # Type that includes all tunable parameters for @VM.create.
Line 2497: #
Line 2498: # @cpu: Limits of CPU and emulator thread.
Line 2499: #
Line 2500: # Since: 4.10.0
4.10.3?
Line 2501: ##
Line 2502: {'type': 'TuneType',
Line 2503: 'data': {'cpu': 'CpuTuneParams'}}
Line 2504:
....................................................
File vdsm/libvirtvm.py
Line 815: return
Line 816:
Line 817: for tuneKey, tuneValue in self.conf['tune'].iteritems():
Line 818: funName = '_append' + tuneKey.capitalize() + "Tune"
Line 819: tuneFun = getattr(self, funName)
Shouldn't we check before we call that?
Or is it intentional that it'll throw an exception during creation?
Honestly I don't really think this is a good idea
Line 820: tuneFun(tuneValue)
Line 821:
Line 822: def _appendAgentDevice(self, path, name):
Line 823: """
--
To view, visit http://gerrit.ovirt.org/8445
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76e9b9d291d4801965163774ba45d15b39a77471
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
