Dan Kenigsberg has posted comments on this change.
Change subject: test_getIfaceByIP changes for IBM POWER(ppc64) architecture
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File tests/capsTests.py
Line 89: route_file = 'route_info.out'
Line 90: elif arch == 'ppc64':
Line 91: route_file = 'route_info_ppc64.out'
Line 92: else:
Line 93: raise SkipTest("Unsupported Architecture")
please add arch to the SkipTest exception string, to help future users.
Line 94: for res, i in zip(expectedRes, ip):
....................................................
File tests/route_info_ppc64.out
Line 1: Iface Destination Gateway Flags RefCnt Use Metric
Mask MTU Window IRTT
Line 2: wlan0 0AC98100 00000000 0001 0 0 0
FFFFFF00 0 0 0
is this a raw output? or have the tabs been transformed into spaces somehow?
is the only difference from x86 is endianness? if so, how about having the same
logical content as of tests/route_info.out ?
Line 3: virbr0 C0A87A00 00000000 0001 0 0 0
FFFFFF00 0 0 0
--
To view, visit http://gerrit.ovirt.org/10181
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40178f44b5ab2602769aa4c70a5e54564f9f360e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Pradipta Banerjee <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
