Yaniv Bronhaim has posted comments on this change. Change subject: change of the isRunning function ......................................................................
Patch Set 1: Verified (1 inline comment) - still need to add unit tests for each case. - we need to verify that after prepareForShutdown, svdsm dies and initializes new instance properly .................................................... File vdsm/supervdsm.py Line 66: Line 67: with self._supervdsmProxy.proxyLock: Line 68: try: Line 69: # make sure supervdsmServer works right Line 70: self._supervdsmProxy.isRunning() my mistake. you call to supervdsmServer directly Line 71: except: Line 72: self._supervdsmProxy.kill() Line 73: self._supervdsmProxy.launch() Line 74: -- To view, visit http://gerrit.ovirt.org/10236 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib25809d4416f26bc95dc72e7b32b8b2a17a71879 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <lvro...@linux.vnet.ibm.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
