Shu Ming has posted comments on this change. Change subject: adding getHardwareInfo API to vdsm ......................................................................
Patch Set 19: Looks good to me, but someone else must approve (1 inline comment) A nit inline. .................................................... File vdsm/Makefile.am Line 31: clientIF.py \ Line 32: configNetwork.py \ Line 33: debugPluginClient.py \ Line 34: dummybr.py \ Line 35: dmidecodeUtil.py \ It might be more reasonable to move this file into line "dist_vdsmpylib_PYTHON". Line 36: guestIF.py \ Line 37: hooking.py \ Line 38: hooks.py \ Line 39: kaxmlrpclib.py \ -- To view, visit http://gerrit.ovirt.org/9258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic429ef101fcf9047c4b552405314dc7ba9ba07a0 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Andrew Cathrow <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Pradipta Banerjee <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
