Dan Kenigsberg has posted comments on this change.

Change subject: Check if log file exist on startup and log is accessible
......................................................................


Patch Set 2:

> what unforeseen regression ??

http://gerrit.ovirt.org/9700/ seemed benign, and I've acked it, but it ended up 
crashing vdsm if vdsm.log was missing.
Similar issues may lurk in this version. I'm not saying that it is not a good 
patch, I was saying that it may be too risky at this stage of the release.

Hateya, do you really think this should be pushed urgently into ovirt-3.2?

--
To view, visit http://gerrit.ovirt.org/10313
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05f4eae90c9388302dc316af41bba7256cecacf7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to