Vinzenz Feenstra has posted comments on this change.
Change subject: Fix race in ProtonReactor and add better delivery semantics
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm_api/jsonrpc/protonReactor.py
Line 27:
Line 28: class ProtonContext(object):
Line 29: log = logging.getLogger("jsonrpc.ProtonContext")
Line 30:
Line 31: def __init__(self, reactor, messageQueue, cxtr, msg):
Well, it may be well established between proton guys, however no one of us is
one of them.
At least put there a comment, please. The only context where I found this as
being referred to is in context of proton, if I would not have put there the
word 'connector' into google I wouldn't even have known that.
It's fine if it is their thing, but we're not them, and other people besides
you should at some point also be able to understand this. It's not helping
anyone if everything you do is only understood by you.
If this would be your own private project, well go ahead and do whatever you
would like to do, but this is a community project and I don't think that this
kind of short cuts in code is in anyway constructive. There's no and absolutely
no sane reason for having this as short as it is at the moment.
Line 32: self._reactor = reactor
Line 33: self._msg = msg
Line 34: self._mq = messageQueue
Line 35: self._cxtr = cxtr
--
To view, visit http://gerrit.ovirt.org/10256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie53d6f4b8a119f8a9e366b717c22ba38bcc99e80
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
