Federico Simoncelli has posted comments on this change. Change subject: stats: compute the iso prefix asynchronously ......................................................................
Patch Set 2: (2 inline comments) .................................................... File vdsm/storage/domainMonitor.py Line 188: if self.domain is None: Line 189: self.domain = sdCache.produce(self.sdUUID) Line 190: Line 191: if self.isIsoDomain is None: Line 192: isIsoDomain = self.domain.isISO() Because every access to self.domain can fail. If we set self.isIsoDomain here we might not set self.isoPrefix and never try again in the future (see condition at 191). Line 193: if isIsoDomain: Line 194: self.isoPrefix = self.domain.getIsoDomainImagesDir() Line 195: self.isIsoDomain = isIsoDomain Line 196: .................................................... File vdsm/storage/sp.py Line 1430: if sdStatus != sd.DOM_ACTIVE_STATUS or sdUUID not in repoStats: Line 1431: continue Line 1432: Line 1433: if repoStats[sdUUID]['isoprefix']: Line 1434: poolInfo['isoprefix'] = repoStats[sdUUID]['isoprefix'] Few months ago I worked in that area (on the engine side) and as far as I remember the value is used only when a VM with a cdrom is started. I'll double check and test it extensively. Line 1435: Line 1436: # For unreachable domains repoStats will return disktotal and Line 1437: # diskfree as None. Line 1438: if (repoStats[sdUUID]['disktotal'] is not None -- To view, visit http://gerrit.ovirt.org/10305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09b7be78da544547a6ed9d5b440bdb0037004c16 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
