Federico Simoncelli has posted comments on this change. Change subject: pool: refactor getInfo and getRepoStats ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/storage/sp.py Line 1441: Line 1442: # For unreachable domains repoStats will return disktotal and Line 1443: # diskfree as None. Line 1444: if (repoStats[sdUUID]['disktotal'] is not None Line 1445: and repoStats[sdUUID]['diskfree'] is not None): The logic is that if both are *not* None, they're valid. The comment seems appropriate. This is a refactor so I don't want to change the logic, although I could improve the comment if you want to suggest a more appropriate one. Line 1446: domInfo[sdUUID]['disktotal'] = repoStats[sdUUID]['disktotal'] Line 1447: domInfo[sdUUID]['diskfree'] = repoStats[sdUUID]['diskfree'] Line 1448: Line 1449: if not repoStats[sdUUID]['mdavalid']: -- To view, visit http://gerrit.ovirt.org/10304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib151b9d19ea488ebbe4c0921a797ddda08141e49 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
