Dan Kenigsberg has uploaded a new change for review. Change subject: net: drop redundant ifdown/up of bond's nics. ......................................................................
net: drop redundant ifdown/up of bond's nics. Commit 5cabaaa130 has introduced a logic that we are trying to eliminate: we should not ifdown a bonded nic directly, initscripts do it for us. Change-Id: Ia87fe1327448f3d859372be00b9ea8cd19d62e50 Signed-off-by: Dan Kenigsberg <[email protected]> --- M vdsm/configNetwork.py 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/10584/1 diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py index 5290436..7a076f9 100755 --- a/vdsm/configNetwork.py +++ b/vdsm/configNetwork.py @@ -1180,15 +1180,10 @@ cf = netinfo.NET_CONF_PREF + bonding configWriter._updateConfigValue(cf, 'MTU', DEFAULT_MTU, False) for nic in nics: - ifdown(nic) cf = netinfo.NET_CONF_PREF + nic configWriter._updateConfigValue(cf, 'MTU', DEFAULT_MTU, False) ifup(bonding) - # NICs must be activated in the same order of boot time - # to expose the correct MAC address. - for nic in nicSort(nics): - ifup(nic) def clientSeen(timeout): -- To view, visit http://gerrit.ovirt.org/10584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia87fe1327448f3d859372be00b9ea8cd19d62e50 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
