Vinzenz Feenstra has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
......................................................................
Patch Set 11: (3 inline comments)
....................................................
File vdsm/BindingXMLRPC.py
Line 327: def vmDesktopSendHcCommand(self, vmId, message):
Line 328: vm = API.VM(vmId)
Line 329: return vm.desktopSendHcCommand(message)
Line 330:
Line 331: def vmHibernate(self, vmId, target=None):
Yes, this is the old behaviour, here was just a name change of the variable to
reflect the purpose better. It's a target now and not only volume handle
Line 332: vm = API.VM(vmId)
Line 333: return vm.hibernate(target)
Line 334:
Line 335: def vmMonitorCommand(self, vmId, cmd):
....................................................
File vdsm_cli/vdsClient.py
Line 61: LEAF_VOL = 8
Line 62:
Line 63: # Guest Hibernate
Line 64: HIBERNATE_TARGET_DISK = "disk"
Line 65: HIBERNATE_TARGET_MEMORY = "mem"
These are the constants for vdsClient, there's no import possible from vdsm
they're not installed together so far.
Line 66: HIBERNATE_TARGET_DEFAULT = HIBERNATE_TARGET_DISK
Line 67:
Line 68:
Line 69: def validateArgTypes(args, conv, requiredArgsNumber=0):
....................................................
File vdsm/vm.py
Line 976: 'sys_shutdown_timeout',
Line 977: self.guestAgent.desktopShutdown,
timeout,
Line 978: message)
Line 979:
Line 980: def hibernate(self, target='disk'):
This should be the constant
Line 981: return self._shutdownCommand('Prepare for hibernate', 0,
Line 982: 'sys_hibernate_timeout',
Line 983: self.guestAgent.hibernate,
target)
Line 984:
--
To view, visit http://gerrit.ovirt.org/1121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
