Livnat Peer has posted comments on this change. Change subject: [WIP] migration network custom property ......................................................................
Patch Set 1: I would prefer that you didn't submit this The migration network should not be set on VM level, it should be part of the host configuration or be sent by the engine per migration command. having the migration network associated with a VM is a hack I see no reason to push. In addition, IMO, the custom properties should be used for the hooks and not be used by the regular VDSM flows, which should used parameters from well defined API. -- To view, visit http://gerrit.ovirt.org/10696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e0d50d6e9aa13758babc5d5bdd4d78ff51f9d95 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
