Deepak C Shetty has posted comments on this change.
Change subject: functional tests: Wait till backend server of storage
connection reference is connected
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Provided one suggestion, to help improve how timeout can be tweaked by
different backened based on their complex setup/connection logic. Pls have a
loook.
....................................................
File tests/functional/xmlrpcTests.py
Line 363: for _refid, status in r['results'].iteritems():
Line 364: self.asserts.assertEquals(status, 0)
Line 365: self.asserts.retryAssert(
Line 366: partial(self._assertBackendConnected, connections),
timeout=40)
Line 367:
I like the concept of BackendServer superclass. Good thinking.
I am not sure if timeout=40 is less/more for all different types of backend. It
depends, so hardcoding is not good here. How about getting timeout using a
function, so that different backends can override and provide optimum value as
needed. For eg: _connectBackendTimeout() will return 40 and it can be
overridden by derived class if need be. Alternatively, we can have the
'connections' dict returned by _createBackend() have 'timeout' as a key with
the appropriate value filled in by the derived class, if its not present, u can
default to 40. This helps different backend tweak the default timeout as needed.
Line 368: def _genTypeSpecificArgs(self, connections, rollback):
Line 369: raise RuntimeError("Not implemented")
Line 370:
Line 371: def prepare(self, backendDef, rollback):
--
To view, visit http://gerrit.ovirt.org/10352
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I466b8e8cbfe6e1b04f8ad902f54fa1177b746feb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
