Saggi Mizrahi has posted comments on this change. Change subject: WIP storage: Alert for using vdsm.conf nfs_mount_options ......................................................................
Patch Set 2: I thought you missed my point. I fully understand why and when the alerts are being use. I gave -2 because this involves a schema change and creates "A mechanism to send the alert". I don't want any mechanism put up to the supported API without fully thinking about how it affects the rest of VDSM. If you want to add a mechanism you have to send and RFC like everyone else and show what the needs are and make sure it also addresses the needs of other subsystems. Just as an example, the alert is attached to getCapabilities() instead of being tied to the object the alert relates to. This means that alerts that are not related to the entire host don't fit to this mechanism. Further more, I don't see why we need a special alert struct. Why can't we reuse the error struct? -- To view, visit http://gerrit.ovirt.org/8979 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8520238e0b41eb95d035128681dc3b71a953e644 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
