Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix the rest of vdsm storage pep8 issues.
......................................................................
Patch Set 1:
Output of gitpydiff for helping verification:
antoni@nx01 ~/code/vdsm> gitpydiff
checking vdsm/storage/dispatcher.py
checking vdsm/storage/image.py
checking vdsm/storage/iscsi.py
1 difference(s)
first file: vdsm/storage/iscsi.py
second file: /tmp/pydiff/vdsm/storage/iscsi.py
((273, '=='), (279, 'is'))
checking vdsm/storage/resourceManager.py
2 difference(s)
first file: vdsm/storage/resourceManager.py
second file: /tmp/pydiff/vdsm/storage/resourceManager.py
((370, '=='), (394, 'is'))
((372, '=='), (396, 'is'))
checking vdsm/storage/sp.py
4 difference(s)
first file: vdsm/storage/sp.py
second file: /tmp/pydiff/vdsm/storage/sp.py
((1437, '!='), (1501, 'is not'))
((1437, '!='), (1502, 'is not'))
((1450,
"VG %s's metadata size exceeded critical size:
mdasize=%s mdafree=%s"),
(1516, "VG %s's metadata size exceeded critical size: mdasize=%s mdafree=%s"))
((1931, '=='), (2052, 'is'))
checking vdsm/storage/storage_mailbox.py
checking vdsm/storage/threadPool.py
3 difference(s)
first file: vdsm/storage/threadPool.py
second file: /tmp/pydiff/vdsm/storage/threadPool.py
((111,
"Compare(Getattr(Name('self'), '__isJoining'), [('==', Name('True'))])"),
(112, "Getattr(Name('self'), '__isJoining')"))
((196, "Compare(Getattr(Name('self'), '__isDying'), [('==', Name('True'))])"),
(198, "Getattr(Name('self'), '__isDying')"))
((191, "Compare(Getattr(Name('self'), '__isDying'), [('==', Name('False'))])"),
(193, "Not(Getattr(Name('self'), '__isDying'))"))
antoni@nx01 ~/code/vdsm>
--
To view, visit http://gerrit.ovirt.org/10742
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I246024ef8de59a357504b5101cbada24aaaa80a2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
