Dan Kenigsberg has posted comments on this change. Change subject: migrateStatus() progress report ......................................................................
Patch Set 11: (2 inline comments) .................................................... File vdsm/libvirtvm.py Line 403: Line 404: while not self._stop.isSet(): Line 405: self._stop.wait(self._MIGRATION_MONITOR_INTERVAL) Line 406: # jobInfo reference: Line 407: # http://libvirt.org/html/libvirt-libvirt.html#virDomainJobInfo comment unrelated to this patch. Line 408: (jobType, timeElapsed, _, Line 409: dataTotal, dataProcessed, dataRemaining, Line 410: memTotal, memProcessed, memRemaining, Line 411: fileTotal, fileProcessed, _) = self._vm._dom.jobInfo() .................................................... File vdsm/vm.py Line 116: def getStat(self): Line 117: """ Line 118: Get the status of the migration. Line 119: """ Line 120: if self._monitorThread is not None: if migration was canceled, or failed - you still report the last known progress. I am not sure it makes sense. Line 121: # fetch migration status from the monitor thread Line 122: self.status['progress'] = int( Line 123: float(self._monitorThread.data_progress + Line 124: self._monitorThread.mem_progress) / 2) -- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
