Pradipta Banerjee has posted comments on this change.
Change subject: Improve dom xml gereration
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 643:
Line 644: oselem = XMLElem('os')
Line 645: self.dom.appendChild(oselem)
Line 646: oselem.newChild('type', text='hvm', arch='x86_64',
Line 647: machine=self.conf.get('emulatedMachine',
'pc'))
We should try to avoid hard coding the arch to x86_64 to the extent possible.
Why not take the arch from the running platform and set it to the appropriate
value ?
Line 648:
Line 649: qemu2libvirtBoot = {'a': 'fd', 'c': 'hd', 'd': 'cdrom', 'n':
'network'}
Line 650: for c in self.conf.get('boot', ''):
Line 651: oselem.newChild('boot', dev=qemu2libvirtBoot[c])
--
To view, visit http://gerrit.ovirt.org/10054
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib936740fcbeeee551e13abfed7fd91f2a159e351
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Pradipta Banerjee <bpra...@in.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shao...@linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
