Federico Simoncelli has posted comments on this change. Change subject: udev: Race fix- load and trigger dev rule(#891300) ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/supervdsmServer.py Line 225: def setSafeNetworkConfig(self): Line 226: return configNetwork.setSafeNetworkConfig() Line 227: Line 228: @logDecorator Line 229: def udevReloadRules(self, guid): Indeed the first version of this patch did what you're asking (also considering to minimize the number of methods exposed) but the code seemed sloppy and it didn't fit with the whole rest of the file where (nonetheless) each operation is very specific. To improve the situation maybe we can keep the three methods separated (with reload and settle as private methods), and make udevTrigger (accepting multiple guids) call them. Line 230: cmd = [EXT_UDEVADM, 'control', '--reload-rules'] Line 231: rc, out, err = misc.execCmd(cmd, sudo=False) Line 232: if rc: Line 233: raise OSError(errno.EINVAL, "Could not reload-rules for device \ -- To view, visit http://gerrit.ovirt.org/10758 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3b2008a3d9df2dcaf54190721c2dd9764338627 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Lee Yarwood <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
