Dan Kenigsberg has posted comments on this change.
Change subject: AdvancedStatsThread: Rotate duplicated stats log
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/logger.conf.in
Line 66: args: []
Line 67: formatter: none
Line 68:
Line 69: [handler_statslog]
Line 70: class=logging.handlers.RotatingFileHandler
I am so sorry that I do not recall the issue well, but we used to have a
problem with python's logrotation.
We even bother to install a cron job that attempts to logrotate more often that
logrotate allows (see vdsm/vdsm-libvirt-logrotate )
I suggest that we do the same here.
Line 71: args=('@VDSMLOGDIR@/stats.log', 'a', 104857600, 3)
Line 72: filters=logUtils.TracebackRepeatFilter
Line 73: level=DEBUG
Line 74: formatter=long
--
To view, visit http://gerrit.ovirt.org/8884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ee04d8d82e2a14b0a003627981c28e5e64a46ab
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
