Zhou Zheng Sheng has posted comments on this change.
Change subject: tests/functional: Add GlusterSD functional test
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File tests/functional/xmlrpcTests.py
Line 404: rootDir = tempfile.mkdtemp(prefix='glusterfs')
Line 405: undo = lambda: os.rmdir(rootDir)
Line 406: rollback.prependDefer(undo)
Line 407: os.chown(rootDir, uid, gid)
Line 408: os.chmod(rootDir, 0755)
What's the usage of 'rootDir'? Is it for creating a testing GlusterFS volume on
demand?
As you mentioned earlier, you will add code to create GlusterFS volume in the
test so that we will not have to setup one manually. For now can it check if
the volume exists otherwise raise a SkipTest("Can not find GlusterFS volume
localfs:testvol, please setup manually") ?
Line 409:
Line 410: connections = {}
Line 411: for uuid, conDict in backendDef.iteritems():
Line 412: spec = conDict['spec']
--
To view, visit http://gerrit.ovirt.org/10196
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe27b138d78e0922a6455e0984813823a98aeb53
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
